Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure kubevirt-csi containers all have resource.Requests and PullPolicy set #1816

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Ensure kubevirt-csi containers all have resource.Requests and PullPolicy set #1816

merged 1 commit into from
Oct 20, 2022

Conversation

davidvossel
Copy link
Contributor

Some of our KubeVirt csi containers didn't have resource requests and pull policy set. This wasn't caught by CI initially when kubevirt-csi was merged due to this openshift/release issue that caused the presubmit not to use the latest CPO/HCCO in the pr. Now that the ci issue is resolved, we have ci failures due to the requests check.

This PR fixes the following issues in our KubeVirt e2e CI.

    util.go:698: container csi-provisioner in pod kubevirt-csi-controller-c948d65b9-w858n has no resource requests
=== RUN   TestCreateCluster/EnsureAllContainersHavePullPolicyIfNotPresent
    util.go:424: container csi-driver in pod kubevirt-csi-controller-c948d65b9-w858n has doesn't have imagePullPolicy IfNotPresent but Always

@openshift-ci openshift-ci bot requested review from enxebre and sjenning October 19, 2022 14:34
@davidvossel davidvossel mentioned this pull request Oct 19, 2022
Merged
4 tasks
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
davidvossel
davidvossel commented Oct 20, 2022
View reviewed changes
Copy link
Contributor Author

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

qinqon
qinqon approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidvossel
Copy link
Contributor Author

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

@davidvossel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 3fb6d26 link false /test capi-provider-agent-sanity
ci/prow/e2e-ibmcloud-iks 3fb6d26 link false /test e2e-ibmcloud-iks
ci/prow/kubevirt-e2e-kubevirt-gcp-ovn 3fb6d26 link false /test kubevirt-e2e-kubevirt-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8d93c27 into openshift:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon qinqon approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidvossel @qinqon @openshift-merge-robot